Skip to content

Conversation

@sbc100
Copy link
Collaborator

@sbc100 sbc100 commented Oct 30, 2024

No description provided.

@sbc100 sbc100 requested a review from kripken October 30, 2024 00:43
@sbc100 sbc100 changed the title Use nullish assignment in file_packager.py Use nullish assignment in file_packager.py. NFC Oct 30, 2024
Copy link
Member

@kripken kripken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we run the transpiler on file packager output? When we combine that output with the main JS we do, but users can also run file packager output directly.

@sbc100
Copy link
Collaborator Author

sbc100 commented Oct 30, 2024

Do we run the transpiler on file packager output? When we combine that output with the main JS we do, but users can also run file packager output directly.

If users run the file packager directly it think its reasonable to generate modern JS and depend on users to transpile it if they want to. Users of the stand alone file packager I fairly few and likely more advanced so I think its reasonable for them to understand such things.

@kripken
Copy link
Member

kripken commented Oct 30, 2024

Fair point. Sounds reasonable to me. But perhaps we should add a changelog entry for this, as it is a breaking change potentially for such users? Something like

The file packager tool will now emit more modern JS. When emcc transpiles code to support older browsers it will convert that code together with all the rest (using Babel), but if you run the file packager directly yourself then you may need to do so manually (if you want to support legacy browsers).

@sbc100 sbc100 force-pushed the file_packager branch 2 times, most recently from 571f07c to 0d7ae4e Compare October 30, 2024 18:51
@sbc100 sbc100 enabled auto-merge (squash) October 30, 2024 18:51
@sbc100
Copy link
Collaborator Author

sbc100 commented Oct 30, 2024

Done

@sbc100 sbc100 merged commit 0bf241c into emscripten-core:main Oct 31, 2024
28 checks passed
@sbc100 sbc100 deleted the file_packager branch October 31, 2024 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants